Fix token boolean filter to work with money & use in templates

[eileenmcnaughton]

Overview

Fix token boolean filter to work with money & use in templates

Before

Templates need to use this construct

{if $isShowTax && '{contribution.tax_amount|raw}' !== '0.00'}

After

{if $isShowTax && {contribution.tax_amount|boolean}}

Technical Details

The |raw comparison is quite confusing because it compares to 0.00 & we need quotes. We are otherwise using the |boolean increasingly so there is some consistency there.

Comments

Note that a bunch of the changed templates are in tests & I feel pretty sure all the templates have test cover on this

I won't do any pro-active template updates here

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Yep & like I said - whatever typo I made is picked up by tests!

CRM_Core_Payment_BaseIPNTest.testSendMailPledge
CRM_Event_Form_Task_BadgeTest.testSubmit
CRM_Member_Form_MembershipRenewalTest.testSubmitRecurCompleteInstantWithMail with data set #0
CRM_Member_Form_MembershipRenewalTest.testSubmitRecurCompleteInstantWithMail with data set #1
CRM_Member_Form_MembershipTest.testSubmit with data set #0
CRM_Member_Form_MembershipTest.testSubmit with data set #1

[eileenmcnaughton]

Ah - I used {tax_amount} when I meant {total_amount}

[colemanw]

Ok, test coverage appears to be extensive.