Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a couple more weights #26250

Merged
merged 1 commit into from
May 17, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

@civibot
Copy link

civibot bot commented May 17, 2023

(Standard links)

@civibot civibot bot added the master label May 17, 2023
@demeritcowboy
Copy link
Contributor

This seems to change the order. I definitely think Manage should be the leftmost one, not needing to scroll off to the right to get to it.
Otherwise seems ok.

@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy that was definitely a mistake from me looking at the row below for what the action was.

I saw some more links in the same file & added weight - I slightly re-ordered them cos it seemed like delete should last - but can change again if you prefer

@demeritcowboy
Copy link
Contributor

Thanks.
It's true that there are some sites that almost never use "Assign to another client", so there's an argument for it being last. In practice it probably doesn't matter too much.
And if I understand right now you can just implement hook_links to change the weight if you want so that seems easy enough.

@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy yep that is the idea. I'm not wedded to re-ordering - I just wanted to add initial weights that where possible give the same actions the same weight across multiple entities - ie I'm going with view = -20, update = -10 & delete = 100 and putting delete always at the right feels consistent - but it's consistency rather than a particular order I'm trying for

@eileenmcnaughton eileenmcnaughton merged commit 457d58f into civicrm:master May 17, 2023
@eileenmcnaughton eileenmcnaughton deleted the weight_linke branch May 17, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants