dev/core#4286 APIv4 - Improve export action handling of $match param #26237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issue was found matching the number given in the pull request title. Please check the issue number. |
|
(Standard links)
|
As of 98511f0 the API Export action now returns the correct value for 'match' by default, so it no longer needs to be hard-coded.
|
@awestuk from memory this was one you logged? |
|
It was - I'll try to test this one tomorrow |
|
Test this please |
|
I haven't tested extensively, but it seems to work as described and is a better default than previously, so better merged than not. |
colemanw
added
the
merge ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improves DX when exporting records from the API Explorer.
See dev/core#4286 Fatal error with managed custom groups containing duplicate field names
Before
"Match" param not automatically supplied.
After
"Match" param automatically set to "name" and augmented for linked entities.
Technical Details
If you try exporting a custom field group, it will default to matching on "name". Fields will cascade to matching on "name" + "custom_group_id". Any option groups related to the fields will also match on "name" and their option values will match on "name" + "option_group_id".