dev/core#4295 SearchKit: check controller class for qfKey when loading legacy search actions for contributions

[ufundo]

Overview

Fix for https://lab.civicrm.org/dev/core/-/issues/4295

Before

Legacy search actions for contributions don't work if they aren't going through CRM_Contribute_Controller_Task

For example: https://lab.civicrm.org/ufundo/ukgiftaid/-/tree/searchkit-actions

After

They work :)

Technical Details

At first I tried using the $task['class'] for the qfKey, but this required modifying the core qfKey validation. An attempt going down that route here https://github.com/ufundo/civicrm-core/tree/task-controller-qfkey-name

I think this is probably much safer!

[civibot]

No issue was found matching the number given in the pull request title. Please check the issue number.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Ooh, this is clever looking up class from menu path. Well done.
I wish it didn't involve an additional sql query, but oh well, that's what you get for supporting legacy stuff.
PS CiviBot has been confused lately about issue numbers... don't worry about it 🤷

[ufundo]

Glad you like it! 😀

Thinking about it, might you get similar mismatches between the controller class and the task class for legacy contact actions? And so maybe this line should use the same approach?

civicrm-core/ext/search_kit/Civi/Api4/Action/SearchDisplay/GetSearchTasks.php

Line 153 in 70c2b33

$key = \CRM_Core_Key::get(\CRM_Utils_Array::first((array) $task['class']), TRUE);

[colemanw]

Thinking about it, might you get similar mismatches between the controller class and the task class for legacy contact actions? And so maybe this line should use the same approach?

Good idea!