Only call transitionComponents when transitioning pending/pay later to completed #26228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o completed Rather than early return when called in error, don't call it
|
(Standard links)
|
|
@mattwire are you able to change this - it just calls the function conditionally instead of doing an early exit, thus making it clearer the circumstances in which this legacy path still kicks in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transition components returns before doing anything if the status is not completed or the previous status is not pending or partially paid. This deprecated function is only called from 2 places so this switches to calling conditionally - which will help us to switch to calling Payment.create in those places....
@seamuslee001 this is the mergeable part of the PR I pinged you from