Remove unreachable validation #26222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some time ago we fixed it such that only Pending and Completed statuses are in the drop box for contribution_status_id. This fragment of code handles an edge case that is no longer reachable - ie when the value is Failed and some other confusing stuff is true
|
(Standard links)
|
|
@eileenmcnaughton looks good, merging this PR |
|
thanks @yashodha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove unreachable validation
Before
Some time ago we fixed it such that only Pending and Completed statuses are in the drop box for contribution_status_id. This fragment of code handles an edge case that is no longer reachable - ie when the value is Failed and some other confusing stuff is true
After
poof
Technical Details
See
civicrm-core/CRM/Event/Form/Participant.php
Line 1516 in 281d81e
Comments