Additional event tokens #26216
Additional event tokens #26216
Conversation
|
(Standard links)
|
|
test this please |
eileenmcnaughton
force-pushed
the
event_tokens
branch
2 times, most recently
from
739998e to
da8499d
Compare
| $tokens['contact_email']['text/html'] = $event['loc_block_id.email_id.email']; | ||
| $tokens['confirm_email_text']['text/plain'] = $event['confirm_email_text']; |
There was a problem hiding this comment.
Is there a reason why these 3 are text/plain rather than text/html?
There was a problem hiding this comment.
I can kind of now looking at the ManageEvent get confirm_email_text and pay_later_text as those are text areas but pay_later_receipt is a wysiwyg https://github.com/civicrm/civicrm-core/blob/master/CRM/Event/Form/ManageEvent/Fee.php#L265 so should be text/html IMO
There was a problem hiding this comment.
Ah great that you should ask ... there is!
If the value is stored as text, which this is, then specifying text/plain here means it gets converted to html in the token processor if rendering in html format.
eileenmcnaughton
force-pushed
the
event_tokens
branch
5 times, most recently
from
c81526d to
d3db19a
Compare
|
@seamuslee001 I just pushed a style fix but this is otherwise working The test changes will conflict with other open PRs so would be good to get this MOPed & I can rebase
|
eileenmcnaughton
force-pushed
the
event_tokens
branch
3 times, most recently
from
f25b456 to
1f3444a
Compare
eileenmcnaughton
force-pushed
the
event_tokens
branch
from
1f3444a to
7c1523e
Compare
| 'type' => 'calculated', | ||
| 'options' => NULL, | ||
| 'data_type' => 'String', | ||
| 'audience' => 'sysadmin', |
There was a problem hiding this comment.
is there a good reason why email 1 is user and email 2 is sysadmin?
There was a problem hiding this comment.
well it's just that people get upset if we put too many tokens in the drop down cos it gets cluttered / easy to pick the wrong one
| 'title' => ts('Event Contact Email'), | ||
| 'name' => 'contact_email', |
There was a problem hiding this comment.
do we need to put an upgrade status message or something about these tokens not working now?
There was a problem hiding this comment.
they should still work cost they are in the deprecated mapping
|
@seamuslee001 is this good to merge now? |
Overview
Additional event tokens
Before
We don't have tokens to deal with the notices in
https://lab.civicrm.org/dev/core/-/issues/4287
After
Tokens added - note that I
followeddeprecated the existing{event.contact_phone}& added a bunch more rather than{event.loc_block_id.phone_id.phone}which would be more correct. I'm on the fence here about switching over (& deprecating the existing format)Technical Details
Comments