Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractAction: Drop @throws from phpdoc of __construct() because it's not thrown #26213

Merged
merged 1 commit into from
May 13, 2023
Merged

AbstractAction: Drop @throws from phpdoc of __construct() because it's not thrown #26213

merged 1 commit into from
May 13, 2023

Conversation

dontub
Copy link

@dontub dontub commented May 13, 2023

Overview

@throws is removed from phpdoc of AbstractAction::__construct().

Before

The phpdoc says \CRM_Core_Exception is thrown, but it isn't.

After

No @throws in phpdoc.

@civibot
Copy link

civibot bot commented May 13, 2023

(Standard links)

@civibot civibot bot added the master label May 13, 2023
@demeritcowboy demeritcowboy merged commit ac65fe4 into civicrm:master May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dontub @demeritcowboy