dev/core#4284 Allow deletion of primary email inline on contact

[larssandergreen]

Overview

It's odd that you can't delete a primary email inline on view contact.

Before

Primary email cannot be deleted. If you clear the email field, you can save if there is no secondary email, but if there is you must switch the primary from the empty row to the new email before saving or else you'll get a form error.

After

Primary email can be deleted. If there are other emails, the next one is set to primary. If there are no other emails, a new empty row is added (with primary already selected).

[civibot]

No issue was found matching the number given in the pull request title. Please check the issue number.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Code looks good to me.
@ufundo can you do a quick r-run to test this?

[ufundo]

I can look at this tomorrow 👍

[ufundo]

Works for me on Firefox and Chrome, resolving an issue I've had a million times. Thanks @larssandergreen 🙌 !

Not a blocker but the next thing that would make it even better would be if it preferred not 'on-hold' emails when selecting a new primary.

( IE in this situation the on hold email is made primary if the primary is deleted, when presumably the 3rd email is preferred

Maybe we could sort on-hold emails to the bottom generally... but one for another day I think!
)

[colemanw]

Thanks for the review @ufundo and good work @larssandergreen!

[larssandergreen]

Thanks @ufundo and @colemanw. I did think about the on hold situation here, but decided it was, as you say, for another day.