Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crmMailingAB/services: catch exception, report error and rethrow #26184

Merged

Conversation

semseysandor
Copy link
Contributor

Overview

If an A/B test's mailing is missing from civicrm_mailings (or can't be loaded for any other reason) opening the relevant A/B test on Mailings >> Manage A/B tests will fail.

Before

WSOD and an empty console, no hint on error.

After

Opening will still fail with a white screen, but there is an error logged to the console, so there is a clue where to start debugging.

@civibot civibot bot added the master label May 9, 2023
@civibot
Copy link

civibot bot commented May 9, 2023

(Standard links)

@eileenmcnaughton
Copy link
Contributor

I suspect we could go further than this on the error handling - but I agree it is better than what there is without this PR

@semseysandor are you in contributors.yml yet?

@eileenmcnaughton eileenmcnaughton merged commit e146f89 into civicrm:master May 10, 2023
@semseysandor
Copy link
Contributor Author

Yes, this is only a small step. I've just spent some time debugging and 90% of it was about finding which line fails. Hopefully, this saves someone that time...

@eileenmcnaughton yes, i'm already in 😄

@semseysandor semseysandor deleted the crmMailingAB-error branch May 10, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants