Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP8 warnings for AddToGroup #26165

Merged
merged 1 commit into from
May 7, 2023
Merged

Fix PHP8 warnings for AddToGroup #26165

merged 1 commit into from
May 7, 2023

Conversation

larssandergreen
Copy link
Contributor

Before

Warnings when not in amtg context.
image

After

Fewer warnings (still some for showHide.tpl).
image

Technical Details

Was able to simplify as {$group.title} was not actually used and we already had {$group.id} in {$form.group_id.value}.

@civibot civibot bot added the master label May 7, 2023
@civibot
Copy link

civibot bot commented May 7, 2023

(Standard links)

@demeritcowboy demeritcowboy merged commit 5747d3f into civicrm:master May 7, 2023
@larssandergreen larssandergreen deleted the php-warning-for-add-to-group branch May 24, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larssandergreen @demeritcowboy