dev/core#4103 Don't show admin only price fields on Registration or Contribution page previews #26103
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issue was found matching the number given in the pull request title. Please check the issue number. |
|
(Standard links)
|
|
jenkins retest this please |
larssandergreen
deleted the
don't-show-admin-only-price-fields-on-event-preview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When not logged in, Event Registration or Contribution page previews should not show (part of) admin-only price fields — they should show a preview of what people using the page will see. See issue for steps to replicate.
Before
There is an admin-only price field here that has its amount shown when previewing the Registration or Contribution page when not logged in.
After
Now the price field is not shown.
Price field is still shown normally to logged-in users and in the price set preview.