dev/core#1321 - SearchKit - Limit operator list for array fields

[colemanw]

Overview

Implements suggestion from https://lab.civicrm.org/dev/core/-/issues/1321#note_58735 to limit operators in SearchKit for fields that store array data.

Before

Searching on an array field like "Contact Subtype" is confusing in SearchKit, as the default "=" operator doesn't work as expected.

After

Default is now "CONTAINS" which correctly searches within arrays. Only sensible operators are available.

[civibot]

No issue was found matching the number given in the pull request title. Please check the issue number.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[larssandergreen]

I have reviewed, makes sense in general, code looks good, r-run works.

The only question I have is about field.data_type === 'Array'. It looks to me like the options for arrays are Is One Of / Not One Of (e.g. for In Groups, With Tags). So maybe we should only do this for serialized fields? To be clear, it works as expected for everything I can think of (I can't find any other array fields other than In Groups and With Tags), but maybe this would be confusing or potentially have other consequences.

[larssandergreen]

Just added a related issue to add NOT CONTAINS to API and SK.

[colemanw]

Merging per review. Thanks @larssandergreen
We'll address follow-up in your other issue.