[Test] Strictness fixes - CiviUntTestBaseClass
#26011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
commented
Apr 5, 2023
| /** | ||
| * Test civicrm note create() using example code. | ||
| */ | ||
| function testNoteCreateExample() { |
There was a problem hiding this comment.
this is actually AFTER the class closes...
eileenmcnaughton
commented
Apr 5, 2023
| * | ||
| * @return array | ||
| */ | ||
| public function noteCreate(int $contactID): array { |
There was a problem hiding this comment.
moved to only class that calls it
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes to typing, etc in test class
Two functions moved from the base class to the only class to call them