Strictness cleanups in test class #26005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
commented
Apr 4, 2023
| $expected = trim((preg_replace('/[ \r\n\t]+/', ' ', $expected))); | ||
| $actual = trim((preg_replace('/[ \r\n\t]+/', ' ', $actual))); | ||
| $this->assertEquals($expected, $actual, $message); | ||
| public function assertLike(string $expectedSQL, string $actualSQL, string $message = '') { |
There was a problem hiding this comment.
hmm IDE made params the same as parent - do these just duplicate parent?
There was a problem hiding this comment.
Yep - fn can go
eileenmcnaughton
commented
Apr 4, 2023
| * @param $actual | ||
| * @param string $message | ||
| */ | ||
| public function assertLike($expected, $actual, $message = '') { |
There was a problem hiding this comment.
turns out to be in parent 5.15 release notes seem to indicate there was some consolidation of it then
eileenmcnaughton
commented
Apr 4, 2023
| @@ -2547,12 +2548,10 @@ protected function eventPriceSetCreate($feeTotal, $minAmt = 0, string $type = 'T | |||
| } | |||
| $priceFieldID = $this->callAPISuccess('PriceField', 'create', $paramsField)['id']; | |||
| $this->ids['PriceField']['event_' . strtolower($type)] = $priceFieldID; | |||
| $this->_ids['price_field'] = [$priceFieldID]; | |||
There was a problem hiding this comment.
This might cause test fails - but it is extraneous so I will fix the tests if so. PHP 8 wouldn't like this
eileenmcnaughton
force-pushed
the
strict_test
branch
5 times, most recently
from
4188615 to
b4abbb8
Compare
eileenmcnaughton
force-pushed
the
strict_test
branch
from
b4abbb8 to
3d28114
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Strictness cleanups in test class
Before
In strict mode we see
After
I removed the sha bit - that randomisation is just a work-around for sloppy cleanup anyway - if the cleanup is done between tests we don't need to randomise
Technical Details
Various other minor cleanups
Comments