BAO - Deprecate setIsActive BAO functions
#25976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
force-pushed
the
deprecateSetIsActive
branch
from
2a0710c to
f280e26
Compare
colemanw
force-pushed
the
deprecateSetIsActive
branch
from
f280e26 to
e9d6557
Compare
| */ | ||
| public static function setIsActive($id, $is_active) { | ||
| Civi::cache('fields')->flush(); |
There was a problem hiding this comment.
I guess this could cause them not to flush but OTOT it is deprecated...
|
Yep - they all look good. Cloudy with a chance of meatballs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Sprinkles a garnish of deprecation annotations and notices to the copypasta function
setIsActivewhich infest the BAO like meatballs on spaghetti code. 🍝 🧀Before
Functions exist, mostly unused outside of unit tests
After
Functions still exist, but annotated
@deprecated. The unused ones are given noisy deprecations.