Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#3804 - Fix recently performed activities on case dashboard when no upcoming exist #25954

Merged

Conversation

demeritcowboy
Copy link
Contributor

Overview

This is the same as #24261 but is a reviewer's cut with the added test and requested changes.

https://lab.civicrm.org/dev/core/-/issues/3804

Before

  1. Make sure there are no upcoming case activities. One way to do this is create a backdated case with a start date 2 years ago, then change the status of any scheduled ones to completed.
  2. Create a recent case activity, e.g. backdate it 2 days and mark it completed.
  3. Visit the case dashboard. Note it does not show the recent activity.

Unit test fails with Failed asserting that '0' matches expected 1.

After

Better

Technical Details

Count was cached without regard to type.

Comments

@civibot
Copy link

civibot bot commented Mar 29, 2023

No issue was found matching the number given in the pull request title. Please check the issue number.

@civibot
Copy link

civibot bot commented Mar 29, 2023

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Straight forward change, explained well, with test, based on previous patch MOP

@eileenmcnaughton eileenmcnaughton merged commit 3a42ce2 into civicrm:master Mar 29, 2023
@demeritcowboy
Copy link
Contributor Author

Thanks!

@demeritcowboy demeritcowboy deleted the case-dashboard-recent branch March 29, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants