(dev/core#4188) Update APIv4 tests for phpunit9 compatibility #25947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests failed on `phpunit9` because upstream swapped out around the semantics of `assertContains()`. The specific issue is whether an array like `["1","2","3"]` contains the value `2`. * `assertContains()` in phpunit8 says yes. * `assertContains()` in phpunit9 says no. * `assertContainsEquals()` in both phpunit8+phpunit9 says yes.
|
(Standard links)
|
This was referenced Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
These tests failed on
phpunit9because upstream swapped around the semantics ofassertContains().The specific issue is whether an array like
["1","2","3"]contains the value2.Before
assertContains()in phpunit8 says yes => tests pass.assertContains()in phpunit9 says no => tests fail.After
assertContainsEquals()in both phpunit8+phpunit9 says yes => tests pass.