Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittant test fail #25924

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fix intermittant test fail

Before

The altered lines consistently fail for me when I run the test in isolation

image

I'm not sure why it doesn't fail elsewhere but obviously it relates to some difference at the php level

After

Fixed to pass

Technical Details

The failure relates to the fact that $expected has no rounding & what has been saved to the db does have rounding - while this is a topic in it's own right - it's not the intent of this test to have an opinion on rounding - only on the discount having been applied

Comments

@civibot
Copy link

civibot bot commented Mar 25, 2023

(Standard links)

@civibot civibot bot added the master label Mar 25, 2023
@seamuslee001 seamuslee001 merged commit b8cb959 into civicrm:master Mar 26, 2023
@seamuslee001 seamuslee001 deleted the mem_test branch March 26, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants