Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix intermittant test fail
Before
The altered lines consistently fail for me when I run the test in isolation
I'm not sure why it doesn't fail elsewhere but obviously it relates to some difference at the php level
After
Fixed to pass
Technical Details
The failure relates to the fact that
$expected
has no rounding & what has been saved to the db does have rounding - while this is a topic in it's own right - it's not the intent of this test to have an opinion on rounding - only on the discount having been appliedComments