Skip to content

Fix recently added import url #25895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Fix recently added import url #25895

merged 1 commit into from
Mar 23, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

my head hurts - every other import url follows the other format - ie civicrm/import/contribution & is
defined in Import.xml

Consistency wishmistancy

my head hurts - every other import url follows the other
format - ie civicrm/import/contribution & is
defined in Import.xml

Consistency wishmistancy
@civibot
Copy link

civibot bot commented Mar 22, 2023

(Standard links)

@civibot civibot bot added the master label Mar 22, 2023
@colemanw
Copy link
Member

@eileenmcnaughton so should this one be moved to the xml?

@eileenmcnaughton
Copy link
Contributor Author

@colemanw this matches the xml - I have a bug-bear that the url for this import is slightly different to all the others - hence I got it wrong first go and also that all the others are in Import.xml & this is in the entity-specific - I was on the fence about fixing vs updating to match the xml

@colemanw
Copy link
Member

@eileenmcnaughton I feel like fixing would probably be better, but I'll go ahead and merge this so at least it's not broken.

@colemanw colemanw merged commit c57198d into civicrm:master Mar 23, 2023
@colemanw colemanw deleted the url branch March 23, 2023 16:35
@eileenmcnaughton
Copy link
Contributor Author

@colemanw ^^ would be the right fix (#25907)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants