Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2021 noisily deprecated pdfCommon function #25887

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Mar 21, 2023

Overview

Before

image

Class isn't called from elsewhere - I could rip the whole thing out - but need to re-home loggingOptions

image

After

poof

Technical Details

Comments

@civibot
Copy link

civibot bot commented Mar 21, 2023

(Standard links)

@civibot civibot bot added the master label Mar 21, 2023
@totten
Copy link
Member

totten commented Mar 22, 2023

FWIW, I did find one thing in universe that sort-of uses it - but their compatibility was already broken circa 5.56/5.57, and they already have an open issue to fix it.

@totten totten merged commit 96d550c into civicrm:master Mar 22, 2023
@totten totten deleted the dep_dn branch March 22, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants