Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaHandler - Add IF EXISTS to dropTable function #25881

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Mar 20, 2023

Overview

Prevents errors in the same way dropColumn does by checking that it exists before dropping.

Before

Error if table has already been dropped

After

No error

Comments

This is a tiny piece carved out from #25871

@civibot
Copy link

civibot bot commented Mar 20, 2023

(Standard links)

@demeritcowboy
Copy link
Contributor

api_v3_SyntaxConformanceTest::testInvalidID_delete with data set #22 ('CustomGroup') TypeError: CRM_Core_BAO_SchemaHandler::dropTable(): Argument #1 ($tableName) must be of type string, null given, called in /home/jenkins/bknix-dfl/build/build-0/web/sites/all/modules/civicrm/CRM/Core/BAO/CustomGroup.php on line 1275

@colemanw colemanw merged commit 5894635 into civicrm:master Mar 20, 2023
@colemanw colemanw deleted the dropTable branch March 20, 2023 19:45
@colemanw
Copy link
Member Author

@demeritcowboy - I fixed it by cleaning up some APIv3 screwyness, or at least making it consistently screwy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants