[REF] Minor code simplification - extract getHighlightedFields in Contribution import MapField

[eileenmcnaughton]

Overview

[REF] Minor code simplification - extract getHighlightedFields in Contribution import MapField

Before

The MapField preProcess does 2 things

1. calls the parent
2. assigns 'highlightedFields'

The parent calls assignMapFieldVariables

which assigns highlightedFields based on the output of getHighlightedFields

As there is currently no function for this on Contribution_Import_Form_MapField the parent getHighlightedFields is called. It returns an empty array - which is overwritten in Contribution_Import_Form_MapField::preProcess

After

We extract the code to getHighlightedFields so the parent can assign it. No more need for the preProcess override - but the fields are still highlighted

Technical Details

Minor cleanup

Comments

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Oh what a tangled web!

[eileenmcnaughton]

@colemanw yeah good point - we can untangle it a bit #25869