Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging ReportDetail: update breadcrumb to use CiviCRM Home for disambiguation #25805

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Mar 13, 2023

… with the "Home" Location Type translation.

Overview

This was changed a while back in CiviCRM, when using "Home" for navigation, we instead use "CiviCRM Home".

This makes it easier to disambiguate the translations for "Home" in other languages. For example, in French, "Home" translates to "Accueil" for navigation, and "Résidence" for the Location Type.

@civibot
Copy link

civibot bot commented Mar 13, 2023

(Standard links)

@civibot civibot bot added the master label Mar 13, 2023
@mlutfy
Copy link
Member Author

mlutfy commented Mar 13, 2023

Unrelated fail?


  ok 40 - api\v4\SearchDisplay\SearchSegmentTest::testRangeSearchSegment       
  ok 41 - api\v4\SearchDisplay\SearchSegmentTest::testSegmentCustomField       
  ok 42 - api\v4\SearchDisplay\SearchSegmentTest::testSegmentCalcField         
  1..42                                                                        
  Found EXITCODES=" flexmailer-headless"                                       
  TAP version 13                                                               
  PHPUnit 8.5.27 #StandWithUkraine                            
                                                                               
  Found EXITCODES=" flexmailer-headless"                                       
  /tmp/workspace/CiviCRM-Core-Matrix-PR/BKPROF/dfl/SUITES/phpunit-core-exts/l  
  abel/bknix-tmp                                                               
  [[Load saved options from /home/jenkins/bknix-dfl/build/build-1.sh]]         
  [[Setup MySQL and HTTP for CMS]]                                             
  [[Restore "/home/jenkins/bknix-dfl/build/build-1/web" DB (cms) from file (/  
  home/jenkins/bknix-dfl/build/.civibuild/snapshot/build-1/cms.sql.gz)]]       
  [[Setup MySQL for Civi]]                                                     
  [[Restore "/home/jenkins/bknix-dfl/build/build-1/web" DB (civi) from file (  
  /home/jenkins/bknix-dfl/build/.civibuild/snapshot/build-1/civi.sql.gz)]]     
  [[Setup MySQL for Test]]                                                     
  [[Restore "/home/jenkins/bknix-dfl/build/build-1/web" DB (test) from file (  
  /home/jenkins/bknix-dfl/build/.civibuild/snapshot/build-1/civi.sql.gz)]]     
  Flushing system caches                                                       
  ~/bknix-dfl/build/build-1/web/sites/all/modules/civicrm/ext/sequentialcredi  
  tnotes /tmp/workspace/CiviCRM-Core-Matrix-PR/BKPROF/dfl/SUITES/phpunit-core  
  -exts/label/bknix-tmp                                                        
  TAP version 13                                                               
  PHPUnit 8.5.27 #StandWithUkraine                            
                                                                               
  ok 1 - SequentialcreditnotesTest::testCreateCreditNoteId                     
  1..1                                                                         
  Found EXITCODES=" flexmailer-headless"                                       
  TAP version 13                                                               
  PHPUnit 8.5.27 #StandWithUkraine                            

@totten
Copy link
Member

totten commented Mar 13, 2023

Yeah, the failure in Civi\FlexMailer\ConcurrentDeliveryTest could be an unrelated/timing thing. I've requested a re-run for that part of the suite: https://test.civicrm.org/job/CiviCRM-Manual-Test/48.

@demeritcowboy
Copy link
Contributor

The manual test passed.
But technically that breadcrumb link isn't civicrm home - it's the website home page.
Generally I ignore breadcrumbs, but you're saying it's like this elsewhere? It looks like it's usually "Home"? The only other place I see CiviCRM Home is the browser tab title on the civicrm dashboard, but that is the civicrm home.

…biguation with the Home location type translation
@mlutfy
Copy link
Member Author

mlutfy commented Mar 14, 2023

@demeritcowboy oops I grepped too quickly. I updated to leave it as "Home" but added context => menu, which is what is done for navigation menus dynamically (the context is added by the string extraction, and the string already exists in Transifex).

@demeritcowboy demeritcowboy merged commit be1bc99 into civicrm:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants