[PHP8.2] declare deleteMessage on entityFormTrait

[eileenmcnaughton]

Overview

Php8.2 declare deleteMessage on entityFormTrait

Before

Property used in a getter but not declared. It is declared on some but not all of the classes that implement the trait

After

Declared on the trait, removed from implementing classes

Technical Details

Comments

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

all the other tpl places have |escape so I checked & here is what is assigned

public function setDeleteMessage() {
    $this->deleteMessage = '<span class="font-red bold">'
      . ts('WARNING: Deleting this membership will also delete any related payment (contribution) records.')
      . ' '
      . ts('This action cannot be undone.')
      . '</span><p>'
      . ts('Consider modifying the membership status instead if you want to maintain an audit trail and avoid losing payment data. You can set the status to Cancelled by editing the membership and clicking the Status Override checkbox.')
      . '</p><p>'
      . ts("Click 'Delete' if you want to continue.") . '</p>';
  }

[totten]

So... sometimes $deleteMessage is plain-text, and sometimes $deleteMessage is HTML? Oof.
$futureDeveloper will not expect that.

(For most of the plain-text examples in core, they'd probably work in either way. But it could make a difference when dealing with translated strings.)

We probably need an explanatory comment in the code.

[totten]

Spot-checked a few screens, and they looked OK. Tests are passing.