APIv4 - Support match in replaceAction
#25770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the replaceAction to support non-id matching, the same way as the saveAction does. Fixes dev/core#4168
|
(Standard links)
|
|
I'm happy with the test cover for this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This allows the replaceAction to support non-id matching, the same way as the saveAction does.
Fixes dev/core#4168
Before
Can't update tags from SearchKit edit screen (master-only regression)
After
Fixed
Technical Details
The regression was caused by updating the EntityTag api in v4 to use the standard
writeRecordwhich loses its special handling (which was basically an implicitmatch). This fixes it by making it possible to explicitly match.