don't show USPS warning when USPS lookup disabled

[MegaphoneJon]

Overview

I spotted this in my last PR's screenshots.

Before

After

Technical Details

This happened when removing e-notices from the Smarty. However, this array key will always exist because of CRM_Contact_Import_Form_DataSource::getOptionalQuickFormElements.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[MegaphoneJon]

Oh - this also removes these warnings from the page:

    Warning: Trying to access array offset on value of type null in include() (line 117 of /home/jon/local/civicrm-buildkit/app/private/dmaster/default/civicrm/templates_c/en_US/%%88/88C/88CE0B27%%DataSource.tpl.php).
    Warning: Trying to access array offset on value of type null in include() (line 118 of /home/jon/local/civicrm-buildkit/app/private/dmaster/default/civicrm/templates_c/en_US/%%88/88C/88CE0B27%%DataSource.tpl.php).

[eileenmcnaughton]

@MegaphoneJon does this work instead - getOptionalQuickFormElements was an earlier method bug array_value_exists seems cleaner - but both together are bad

--- a/CRM/Contact/Import/Form/DataSource.php
+++ b/CRM/Contact/Import/Form/DataSource.php
@@ -29,19 +29,6 @@ class CRM_Contact_Import_Form_DataSource extends CRM_Import_Form_DataSource {
     return 'contact_import';
   }
 
-  /**
-   * Get any smarty elements that may not be present in the form.
-   *
-   * To make life simpler for smarty we ensure they are set to null
-   * rather than unset. This is done at the last minute when $this
-   * is converted to an array to be assigned to the form.
-   *
-   * @return array
-   */
-  public function getOptionalQuickFormElements(): array {
-    return ['disableUSPS'];
-  }
-

[eileenmcnaughton]

Note - I'll add a not about it in https://docs.civicrm.org/dev/en/latest/security/outputs/#gotcha-2-smarty-notices

[MegaphoneJon]

@eileenmcnaughton That works great. I wasn't sure whether that code was still necessary, I agree this is cleaner.

[eileenmcnaughton]

@MegaphoneJon can you target 5.60? I don't think it needs s stable backport but this is rc-appropriate IMHO as a semi-recent regression

[eileenmcnaughton]

I'm merging this since it's likely no-one else will notice it in the delay between 5.60 & master & getting it merged feels important. We can still choose to backport