(dev/core#4137) Tokens - Filters should be HTML-sensitive #25727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Reporter commented on gitlab
|
| namespace Civi\Token; | ||
|
|
||
| /** | ||
| * This class is a collection of CiviMail filter functions. For example, consider this message: |
There was a problem hiding this comment.
opps - I just noticed the comment incorrectly references CiviMail - which is just one consumer of tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/core/-/issues/4137 presents two issues. This addresses the second issue, wherein the filters
{foo.bar|upper}and{foo.bar|lower}may produce distorted output when handling HTML data.Before
{foo.bar|upper}is strictly treated as plain-text.If the value of
foo.baris markup , then tags and entities will be capitalized incorrectly.After
{foo.bar|upper}is evaluated in a template-sensitive way (as plain text or HTML).If the value of
foo.baris markup, then the textual data will be filtered -- but the tags and entities will be preserve their original values.