Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#4124) Past campaigns are not to be assigned via batch updat… #25687

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

yashodha
Copy link
Contributor

…e/update contributions

Overview

  • Create a campaign with end date in past

campaign

  • Create a profile configured for contribution fields (including the campaign field)

  • Find Contributions, and select a few and use the created profile to update the campaign

  • The campaign is NOT available in the drop down

batch_update

  • On new/edit contributions, you are able to choose the past campaigns as well (which is the correct behavior).
    new_contribution

Before

No past campaigns available for batch update.

After

Past campaigns are available for batch update.

@civibot civibot bot added the master label Feb 28, 2023
@civibot
Copy link

civibot bot commented Feb 28, 2023

(Standard links)

@yashodha
Copy link
Contributor Author

@demeritcowboy Can you please check/merge this?

@demeritcowboy demeritcowboy added the merge ready PR will be merged after a few days if there are no objections label Mar 12, 2023
@demeritcowboy
Copy link
Contributor

I've put merge-ready because for example if you have this profile on a public form or contribution page where you let them choose a campaign, it now shows past campaigns and you might not want that. But this seems an unlikely use of campaigns.

@demeritcowboy demeritcowboy merged commit 8b0ba2a into civicrm:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants