Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Smarty debug to it's own channel #25682

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

I just wrote the docs on the right way to log using this example https://docs.civicrm.org/dev/en/latest/framework/logging/

  • so we should make it the same. I tested locally & this results in the smarty debugging going to a separate file (good).

I personally think we should send all the IPN files off to their own channel but am loath to be pro-active on changing that

Before

Output from smarty secure mode goes into the same log file as all the rest

After

Output from smarty secure mode goes into it's own file

Technical Details

Comments

I just wrote the docs on the right way to log using this example
https://docs.civicrm.org/dev/en/latest/framework/logging/

- so we should make it the same. I tested locally
& this results in the smarty debugging going to a separate file (good).

I personally think we should send all the IPN files off to their
own channel but am loath to be pro-active on changing that
@civibot
Copy link

civibot bot commented Feb 28, 2023

(Standard links)

@civibot civibot bot added the master label Feb 28, 2023
@demeritcowboy demeritcowboy merged commit da5a2c0 into civicrm:master Feb 28, 2023
@eileenmcnaughton eileenmcnaughton deleted the log_smarty branch February 28, 2023 01:38
@eileenmcnaughton
Copy link
Contributor Author

thanks @demeritcowboy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants