distmaker - Fix 'WordPress' entry in JSON report #25424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When publishing a release,
distmaker
produces is a JSON summary about the inputs and outputs. @christianwach found that theWordPress
section was missing from the list of outputs.Before
JSON output is missing something important:
"rev" : "5.58.beta1-2e2455ba34bb2a02c2a886e107b0e20a", "tar" : { "Drupal" : "civicrm-5.58.beta1-drupal.tar.gz", "Joomla" : "civicrm-5.58.beta1-joomla.zip", - "WordPress" : "civicrm-5.58.beta1-wordpress.zip" ...
After
JSON output has something important:
"rev" : "5.58.beta1-2e2455ba34bb2a02c2a886e107b0e20a", "tar" : { "Drupal" : "civicrm-5.58.beta1-drupal.tar.gz", "Joomla" : "civicrm-5.58.beta1-joomla.zip", + "WordPress" : "civicrm-5.58.beta1-wordpress.zip" ...
Technical Details
distmaker
has silly variable names. Grep forWPPACK
andWP5PACK
to see which is more correct.Comments
This is a little finnicky to test. I did do a local
r-run
with this patch and saw the fixed output , but... it is generally easier to test by merging and letting the autobuild run...