Waitlist

[pradpnayak]

Overview

https://lab.civicrm.org/dev/core/-/issues/4087

After

Email should display confirmation text

Before

Waitlist message displayed in email

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Thanks @pradpnayak - can you switch this to the rc branch? 5.58

I'm looking at the original code (before my change to remove CRM_Utils_Array::value which caused this) & it hurts my brain

     $waitStatus = CRM_Event_PseudoConstant::participantStatus(NULL, "class = 'Waiting'");
    if ($waitingStatus = CRM_Utils_Array::value($params['status_id'], $waitStatus)) {
      $this->assign('isOnWaitlist', TRUE);
    }

I guess CRM_Event_PseudoConstant::participantStatus is one of those awful functions that returns an array or a status & I mistook that it would return a status but it returns an array

[pradpnayak]

Hi @eileenmcnaughton

I have switched to 5.58 branch.

[demeritcowboy]

I actually get a "type error" before, not the waitlist message, but regardless this fixes it and seems right.

Test fails unrelated.