dev/core#3960 Remove legacy ar key #24895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issue was found matching the number given in the pull request title. Please check the issue number. |
|
(Standard links)
|
demeritcowboy
added
the
merge ready
|
I'm ok to merge this and am convinced that the key doesn't do, and never did, anything. Unless @totten you have any comments. |
|
+1 for this on 5.56-rc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#3960 Remove legacy ar key
https://lab.civicrm.org/dev/core/-/issues/3960
Before
js error
After
seems to work
Technical Details
I can't see anything using the
keyso I think it is obsolete. This form is one of our earlier attempts at using ajax so I think that might just be something that we evolved away fromComments
Can probably also close https://lab.civicrm.org/dev/core/-/issues/3050 with this merged