-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF][PHP8.2] Add patches to pear upstream packages to fix issues with PHP8.2 #24857
Conversation
(Standard links)
|
It looks like there are some fails on the upstream patch? |
7aae7ac
to
80ad0f0
Compare
@demeritcowboy I think the Upstream test fails are unrelated |
Ok I see they've had those errors for a while. Otherwise this looks good. And there shouldn't be the same issue as zetamail when they're merged upstream since the version here is fixed at a specific version. Although given this is for php 8.2 would it be easier to just wait until they are merged upstream and then update the pear::db version? |
@demeritcowboy well I chose to patch DB because that was the class that the dynamic property was being created on when you look at L 4778 http://svn.php.net/viewvc/pear/packages/DB_DataObject/trunk/DB/DataObject.php?view=markup&pathrev=339312 it does this
Which I think means that we have to patch DB not the dataobject but I suppose we could rip those parts of the DB_DATAObject our of our version instead. |
…h PHP8.2 Remove Pear/DB DB_DataObject patch as not needed
80ad0f0
to
99b9f24
Compare
@demeritcowboy @totten as per discussion here https://lab.civicrm.org/dev/core/-/issues/3958#note_84022 I have pulled the DataObject compatibility patch from this PR and created civicrm/civicrm-packages#354 |
I clicked around a bit. I figure something would fail pretty quickly if it was a problem. |
Overview
This applies some patches / fixes based on upstream PRs to pear/db and pear/core-minimal packages to fix issues in PHP8.2
Before
Pear db and pear core minimal code not compatible for PHP8.2
After
Code seems to work fine for PHP8.2
ping @eileenmcnaughton @demeritcowboy @totten