dev/core#3956 Only show tag search option in Advanced Search when there are tags on activities or cases #24855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Since Advanced search is basically in feature freeze I think this makes sense - as it stays frozen with the current functionality without new stuff like SavedSearch tags bleeding in. |
larssandergreen
deleted the
remove-weird-search-option-for-tagged-SK-searches
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
When there was a tagged SK search, this showed up:
After
No longer shows up.
Shows up as before when tags exist for cases or activities.
Technical Details
I think it makes more sense to check for tags specifically on cases and activities (as this is what is indicated in the help text) rather than looking for any tags on any entities except some list.