Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdminUI - Fix pager settings to be consistent #24845

Merged
merged 1 commit into from
Oct 28, 2022
Merged

AdminUI - Fix pager settings to be consistent #24845

merged 1 commit into from
Oct 28, 2022

Conversation

colemanw
Copy link
Member

Overview

Ensures all pager settings are consistent across the adminUI extension

Before

Some pagers were showing the count and exposing the limit, others were not.

After

Consistent.

@colemanw
AdminUI - Fix pager settings to be consistent
2981acd 
Ensures all pager settings are consistent across the adminUI extension
@civibot
Copy link

civibot bot commented Oct 28, 2022

(Standard links)

@civibot civibot bot added the master label Oct 28, 2022
kurund
kurund approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ready for merging.

@colemanw colemanw merged commit 097b478 into civicrm:master Oct 28, 2022
@colemanw colemanw deleted the adminUiPager branch October 28, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurund kurund kurund approved these changes

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @kurund