Remove notice-causing do-nothing script #24836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove notice-causing do-nothing script
Before
With debugging enabled there is a notice when creating a new custom group
After
poof
Technical Details
The field
inithideboxes
is hiding is 'extends_1'The code sets it to hide when
$initHideBoxes
is SET - which is when there is no group_idSo hidden looks like
And not hidden looks like
However, even without the
initHideBoxes
js something, is already hiding it appropriately - I had to us jscj('#extends_1').show()
to make it show. There is a whole lot of seemingly related show-hide js in the tpl file so I think it became obsolete but was not removedSo - the script appears to do nothing, other than notice out.
I tested r-run on new & edit & when you select a type you DO get the options
Comments