Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notice-causing do-nothing script #24836

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 28, 2022

Overview

Remove notice-causing do-nothing script

Before

With debugging enabled there is a notice when creating a new custom group

image

After

poof

Technical Details

The field inithideboxes is hiding is 'extends_1'

The code sets it to hide when $initHideBoxes is SET - which is when there is no group_id

So hidden looks like

image

And not hidden looks like

image

However, even without the initHideBoxes js something, is already hiding it appropriately - I had to us js cj('#extends_1').show() to make it show. There is a whole lot of seemingly related show-hide js in the tpl file so I think it became obsolete but was not removed

So - the script appears to do nothing, other than notice out.

I tested r-run on new & edit & when you select a type you DO get the options

Comments

In my UI testing & code delving I couldn't see how hiding 'extends_1' was
doing anything. The field didn't seem to be on the page
and the 'extends' files were not hidden....
@civibot
Copy link

civibot bot commented Oct 28, 2022

(Standard links)

@civibot civibot bot added the master label Oct 28, 2022
@yashodha
Copy link
Contributor

@eileenmcnaughton looks good, merging this.

@yashodha yashodha merged commit 07502cb into civicrm:master Oct 28, 2022
@eileenmcnaughton eileenmcnaughton deleted the notice_group branch October 28, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants