SearchKit - Add modulo operator to math function #24830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Instead of a blank field selector with no way to clear it, it now picks the first available field for you so it's easier to clear and replace with a number if you so choose.
colemanw
force-pushed
the
searchKitModulo
branch
from
2955b26 to
768a9f5
Compare
|
Tested this PR on the Drupal demo site provided and confirmed that the modulo operator works as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds support for the modulo operator to SearchKit math equations. This is mostly useful for testing whether a number is even or odd.
Example
The following clause will only return contacts for whom the value of a custom field is an odd number:
Comments
This math widget is a little tricky to use. By default it wants you to compare the field with another field, and switching that to a fixed value (in this case the number 2) means selecting and then deselecting a field to clear it out. I've simplified that process a bit in this PR by auto-picking the first available field so you at least have a way to clear it out immediately and don't have to select a dummy value.