Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchKit - Fix php error when doing math equations in SELECT clause #24829

Merged
merged 1 commit into from
Oct 30, 2022
Merged

SearchKit - Fix php error when doing math equations in SELECT clause #24829

merged 1 commit into from
Oct 30, 2022

Conversation

colemanw
Copy link
Member

Overview

Fixes dev/core#3938

Before

Trying to use math in the select clause fails.

After

Fixed. Test added.

@civibot
Copy link

civibot bot commented Oct 27, 2022

(Standard links)

@civibot civibot bot added the master label Oct 27, 2022
@colemanw
Copy link
Member Author

retest this please

vmanasek
vmanasek approved these changes Oct 30, 2022
View reviewed changes
Copy link

@vmanasek vmanasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing and I did not found any problem and it works.

@colemanw colemanw merged commit 12a9c60 into civicrm:master Oct 30, 2022
@colemanw colemanw deleted the fixSkMath branch October 30, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmanasek vmanasek vmanasek approved these changes

Assignees
No one assigned
Labels
has-test master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @vmanasek