[REF] Cleanup on CRM_Admin_Form_Options

[eileenmcnaughton]

Overview

[REF] Cleanup on CRM_Admin_Form_Options

Before

I coulldn't figure out what the code was doing & why

After

• Form Field contactOptions renamed to contact_type_id - which is almost correct - it has a (hard-coded, I didn't change that) list of contact types to which it adds the mysterious ' "Multiple Contact Merge". Despite this extra it 'mostly' means 'contact_type_id'
• less use of the mysterious $this->_gName - as with most abbreviations the meaning of this is clear right up until the end of the coding session at which point it becomes hard to decipher.
• simplification around the validation of the submitted greeting - understanding this was where I started. I no longer call the cached function because for an admin form reducing complexity is more important that hitting the cache. I decided that all that was happening was it was ensuring that there were not 2 records for the same greeting + contact type + label & I r-run tested to check that didn't happen
  
• separating the check into a function allows sensible levels of code commenting
• I determined the magic last merge option is not actually used for email_greetings so I removed from there

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).