NFC - minor Cleanup in test class #24827
Conversation
|
(Standard links)
|
| 'street_address' => '1 Happy Place', | ||
| 'city' => 'Miami', | ||
| 'state_province' => 'Flordia', | ||
| 'state_province' => 'Florida', |
There was a problem hiding this comment.
I suppose it could be interesting ("What happens when the state_province is wonky?")... but it's clearly not the focus of the test...
👍
eileenmcnaughton
force-pushed
the
test_clean
branch
2 times, most recently
from
caface6 to
e74107f
Compare
| $addFormat = '{contact.state_province}'; | ||
| Civi::settings()->set('address_format', $addFormat); | ||
| $formatted_address = CRM_Utils_Address::getFormattedBillingAddressFieldsFromParameters($params, '99'); | ||
| $this->assertTrue((bool) $formatted_address == 'AL'); | ||
| $this->assertEquals('AL', $formatted_address); |
There was a problem hiding this comment.
so there seems to be trailing new line that is showing up here somehow @eileenmcnaughton
There was a problem hiding this comment.
Hmm - the trailing line isn't new - the old assert permitted it. Ie in the screenshot the first assert passes & the second fails
I suspect it needed brackets around the comparison
There was a problem hiding this comment.
I guess that's what formatted means...
And hence the previous code's (bool) to cast it true which then matched the string which autocasts to true so it always passed. How else do you deal with trailing newlines?
There was a problem hiding this comment.
@demeritcowboy so we could use that pattern to make all our tests pass....
There was a problem hiding this comment.
Or even simpler use the technique @mlutfy discovered: Automatic pass!
There was a problem hiding this comment.
Another winning technique
There was a problem hiding this comment.
eileenmcnaughton
force-pushed
the
test_clean
branch
from
e74107f to
5a2fb6a
Compare
|
Jenkins re test this please |
Overview
NFC - minor Cleanup in test class
Before
After
Technical Details
Comments