Remove always true ifs (label code) #24817
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This function appears to have been split off from a similar function in the past &
$microformat
hard-coded to FALSEHowever, so IF statements from the prior code have persisted - this removes the statements that rely on the value of $microformat which is, as we know, FALSE
Before
Meaningless if statements around fhe value of
$microformat
After
poof
Technical Details
View the diff with https://github.com/civicrm/civicrm-core/pull/24817/files?w=1 to see....
Comments