Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove always true ifs (label code) #24817

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 25, 2022

Overview

This function appears to have been split off from a similar function in the past & $microformat hard-coded to FALSE

image

However, so IF statements from the prior code have persisted - this removes the statements that rely on the value of $microformat which is, as we know, FALSE

Before

Meaningless if statements around fhe value of $microformat

After

poof

Technical Details

View the diff with https://github.com/civicrm/civicrm-core/pull/24817/files?w=1 to see....

Comments

@civibot
Copy link

civibot bot commented Oct 25, 2022

(Standard links)

@civibot civibot bot added the master label Oct 25, 2022
@seamuslee001 seamuslee001 merged commit 87cd355 into civicrm:master Oct 26, 2022
@seamuslee001 seamuslee001 deleted the no_micro branch October 26, 2022 00:22
@eileenmcnaughton
Copy link
Contributor Author

thanks @seamuslee001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants