Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code cleanup - use function to replace a few lines #24811

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 25, 2022

Overview

On trying to figure out what these lines do I discovered similar code elsewhere calling a function which does exactly the same thing

image

is the same as the removed code

image

Before

Duplicate code

After

Exisitng function used instead

Technical Details

Comments

@civibot
Copy link

civibot bot commented Oct 25, 2022

(Standard links)

@civibot civibot bot added the master label Oct 25, 2022
@demeritcowboy demeritcowboy merged commit 790251d into civicrm:master Oct 26, 2022
@eileenmcnaughton eileenmcnaughton deleted the address branch October 26, 2022 19:51
@eileenmcnaughton
Copy link
Contributor Author

thanks @demeritcowboy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants