dev/core#3702 - <af-field> tags are not valid html (ALTERNATE)

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/3702

Alternate to #23917

Before

On dashboard, error DOMDocument::loadHTML(): Tag af-field invalid in Entity

After

Technical Details

See lab ticket for more details.

Comments

Unit test is at #23918

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

Looks pretty good to me. Do you have a preferred way to r-run?

[demeritcowboy]

Visit the civi dashboard. Either use php8 or you can sneak in a \phpQuery::$debug = 2; into the function here.

[totten]

r-run: OK, so I don't actually get the original warning on my php81 environment (bknix-edge / dmaster) out of the box. But the \phpQuery::$debug=2 does help to provoke. Overall steps:

1. Enable afform_admin
2. Pick an afform and enable dashboard support. (This may not actually be needed - but I did it to be sure.)
3. Edited Civi\Afform\Scanner to include \phpQuery::$debug = 2;
4. Open civicrm/dashboard
5. On CLI, run cv flush
6. Reload civicrm/dashboard

At step 6 of the process, I can confirm that the patch cleans things up. (Before the patch, step 6 showed the af-field warnings. With the patch, step 6 looks cleaner. 👍 )

Beyond that... concept seems good, and the test-suite is passing. Merging.

[demeritcowboy]

Thanks!