Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdminUI - Convert "Administer Payment Processors" to SearchKit #24759

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

colemanw
Copy link
Member

Overview

Another notch in the Admin UI utility belt.

Before

image

After

image

Technical Details

This included an APIv4 patch+test to allow filtering by "current_domain" in SearchKit.

Exposes "current_domain" as a choice in SearchKit, and improves API
support for handling it when using pseudoconstant syntax.
@civibot
Copy link

civibot bot commented Oct 17, 2022

(Standard links)

@mattwire
Copy link
Contributor

Nice :-) You beat me to it! I'll see if I can test later

@AlainBenbassat
Copy link
Contributor

I tested it.

There seems to be an error when you edit the payment processor.

  • From the new administer payment processors screen: civicrm/admin/paymentProcessor?reset=1
  • You will see 1 line, i.e. the Test Processor
  • Click the Edit button at the right-hand side
  • A popup window opens with the title "Edit Payment Processor", but the name of the payment processor is empty and all fields seem to be default values. Not the actual values of the record

@colemanw
Copy link
Member Author

Thanks @AlainBenbassat I had forgotten to patch the form to work in standalone mode. I've taken care of it now if you could try once more.

@mattwire
Copy link
Contributor

Tested and working. It would be nice to see the test processor ID in the list but I realise that's not too easy right now.

@mattwire mattwire merged commit 64ee023 into civicrm:master Oct 18, 2022
@colemanw colemanw deleted the skPaymentProcessor branch October 18, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants