SearchKit - Set button size default to btn-xs to match existing UI
#24755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
FYI @Damilare1 |
…elements For buttons in a table, `xs` generally fits the best, so let's make that the default.
|
Apologies @colemanw, I'm just seeing this. Looks like you've made the changes for relationship types. The Civigrant pages are already set to btn-xs. |
Damilare1
reviewed
Oct 17, 2022
| @@ -108,7 +108,7 @@ | |||
| 'editable' => TRUE, | |||
| ], | |||
| [ | |||
| 'size' => 'btn-sm', | |||
| 'size' => 'btn-xs', | |||
There was a problem hiding this comment.
This doesn't seem to work on the test site as the contact type buttons still have the btn-sm class.
There was a problem hiding this comment.
Seems to be some kind of caching issue on the demo site. Not sure what the problem is but I can't reproduce locally.
| @@ -54,7 +54,7 @@ | |||
| label: ts('Buttons'), | |||
| icon: 'fa-square-o', | |||
| defaults: { | |||
| size: 'btn-sm', | |||
| size: 'btn-xs', | |||
There was a problem hiding this comment.
I understand this would set the default button size when adding button to "Tiny" instead of "Small" in the searchkit table. Is this correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
During the sprint one of the screens converted to SearchKit accidentally set the wrong button size, which is an easy mistake to make since the "wrong" size is the default. This fixes it and also changes the default to prevent more such accidents.
Before
Default of
btn-smwhich tends to make tables with lots of buttons feel crowded.After
For buttons in a table,
btn-xsgenerally fits the best, so let's make that the default.