dev/core#3908 Fix permissions for SubscriptionHistory in SearchKit #24719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
wmortada
force-pushed
the
subscriptionhistorypermission
branch
from
3137af0 to
b8f3878
Compare
wmortada
changed the title
|
@colemanw Ready for review |
wmortada
force-pushed
the
subscriptionhistorypermission
branch
2 times, most recently
from
237bbca to
c76ec9f
Compare
colemanw
requested changes
Oct 12, 2022
wmortada
force-pushed
the
subscriptionhistorypermission
branch
from
c76ec9f to
00cadd8
Compare
colemanw
approved these changes
Oct 15, 2022
|
All looks good and tests are passing 👍 |
|
Thanks @colemanw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Users without 'administer CiviCRM' permission are unable to view data from the SubscriptionHistory entity in SearchKit.
See https://lab.civicrm.org/dev/core/-/issues/3908
Before
User unable to view data.
After
User able to view data.