Make mailing name and campaign editable in place on Find Mailings

[larssandergreen]

Overview

There is currently no way to edit the mailing name or campaign for a scheduled, sent or archived mailing in the UI. If you have a naming system for mailings and someone sends a mailing that doesn't conform, you can't fix it and you can't change the campaign if it is incorrect.

Before

Mailing name and campaign not editable.

After

Mailing name and campaign editable in place on Find Mailings.

Technical Details

The id for the tr was changed from crm-mailing_{$row.id}, which does not appear to be used for anything, to mailing-{$row.id}.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

This looks good. Just wondering why was the crm-mailing id a problem? If somebody was targeting it for styling or something this would break that.

[colemanw]

The in-place-edit jQuery code expects a dom id of entity name dash id. I think it's a safe enough change.