Afform - Ensure afField ids contain only allowed characters

[colemanw]

Overview

Ensures the id attribute for afFields only contains characters suitable for an id.

Before

Fieldnames sometimes contain a dot (e.g. custom fields), which is not allowed in the html spec.

After

Funny characters replaced with dashes.

[colemanw]

Test this please

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[jackgleeson]

Hey @colemanw. I can see the new js function running on the front end. However, I haven't been able to find a way to add an ID field that contains a dot or other unwanted character. Could you advise how best to test that? Thanks!

[colemanw]

Hey @colemanw. I can see the new js function running on the front end. However, I haven't been able to find a way to add an ID field that contains a dot or other unwanted character. Could you advise how best to test that? Thanks!

Thanks for looking at this @jackgleeson - just add a custom field to the form. All APIv4 custom fields have a dot in their name. Then check the id of the <input>.

[kurund]

Looks good to me and working as expected.

ready to merge.