When running unit tests don't accidentally overwrite your db

[demeritcowboy]

Overview

Update civicrm.settings.php to abort instead of falling back your "real" db.

Before

As currently written, this if-block will fall back to your "real" db if for whatever reason $GLOBALS['_CV']['TEST_DB_DSN'] isn't set, potentially causing the test sytem to overwrite the data.

  if (CIVICRM_UF === 'UnitTests' && isset($GLOBALS['_CV']['TEST_DB_DSN'])) {
    define('CIVICRM_DSN', $GLOBALS['_CV']['TEST_DB_DSN']);
   }
   else {
     define('CIVICRM_DSN', 'mysql://%%dbUser%%:%%dbPass%%@%%dbHost%%/%%dbName%%?new_link=true%%dbSSL%%');

After

Aborts instead.

Technical Details

I'm not sure why $GLOBALS['_CV']['TEST_DB_DSN'] wasn't set in my case, possibly a windows+cv+drupal8 situation failing to find some path - I don't usually run core tests with that combo. So the actual problem might be elsewhere but I'm thinking better to abort so you can then go search for the problem rather than overwrite the db.

Comments

There might be a legitimate configuration where the expectation is it uses the value in civicrm.settings.php instead of the test db when it's blank, but I'm not sure what that would be.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

In my case cv couldn't find what it needed because on windows you can have a slash mismatch or case-sensitive mismatch between CIVICRM_SETTINGS and the array key in ~/.cv.json, so when it hits https://github.com/civicrm/cv/blob/master/src/SiteConfigReader.php#L67 it finds no match. But I still think this PR is a good idea.

[colemanw]

Makes sense and doesn't affect our testing CI. I pulled it down and confirmed tests still run locally.

[demeritcowboy]

Thanks!